This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
fix(cli): pipe content to the cli from cat it is a stream #482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| }) | ||
| return | ||
| } | ||
|
|
||
| ipfs.files.cat(path, (err, file) => { | ||
| if (err) { | ||
| throw (err) |
There was a problem hiding this comment.
This can be simplified now, since it doesn't matter anymore if the daemon is on, js-ipfs-api also has ipfs.files.cat and it is the same API
There was a problem hiding this comment.
oh cool, didn't know ipfs.files.cat was a thing on js-ipfs-api
|
We can now remove the |
dignifiedquire
force-pushed
the
fix-online-cat
branch
from
c7df77e
to
3e4e2fd
Compare
|
@diasdavid I'm afraid you are mistaken |
|
@dignifiedquire They are aliased here: https://github.com/ipfs/js-ipfs-api/blob/master/src/load-commands.js#L35-L43 |
|
@diasdavid there still is no |
|
@dignifiedquire got it, we missed that one! |
daviddias
force-pushed
the
fix-online-cat
branch
3 times, most recently
from
d43a05d
to
0b53acf
Compare
|
|
||
| function onFile (err, file) { | ||
| if (err) { | ||
| console.log(err) |
daviddias
force-pushed
the
fix-online-cat
branch
from
0b53acf
to
5b8da13
Compare
MicrowaveDev
pushed a commit
to galtproject/js-ipfs
that referenced
this pull request
May 22, 2020
) fix a couple of grammatical errors arrange function index in alphabetical order add more options to ipfs.add doc rename cid-version to cidVersion in the docs closes: ipfs#429 License: MIT Signed-off-by: Prabhakar-Poudel <yuvrajzohan@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found while testing the cli :)