Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

Updates findProvs example #4114

Merged
merged 2 commits into from
Jun 1, 2022
Merged

Updates findProvs example #4114

merged 2 commits into from
Jun 1, 2022

Conversation

d-r-w
Copy link
Contributor

@d-r-w d-r-w commented May 31, 2022

Perhaps this is outdated? findProvs (as mentioned on lines 87-89) is expecting a CID, not a string

Perhaps this is outdated? findProvs (as mentioned on lines 87-89) is expecting a CID, not a string
@welcome
Copy link

welcome bot commented May 31, 2022

Thank you for submitting this PR!
A maintainer will be here shortly to review it.
We are super grateful, but we are also overloaded! Help us by making sure that:

  • The context for this PR is clear, with relevant discussion, decisions
    and stakeholders linked/mentioned.

  • Your contribution itself is clear (code comments, self-review for the
    rest) and in its best form. Follow the code contribution
    guidelines

    if they apply.

Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
Next steps:

  • A maintainer will triage and assign priority to this PR, commenting on
    any missing things and potentially assigning a reviewer for high
    priority items.

  • The PR gets reviews, discussed and approvals as needed.

  • The PR is merged by maintainers when it has been approved and comments addressed.

We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution.
We are very grateful for your contribution!

docs/core-api/DHT.md Outdated Show resolved Hide resolved
@achingbrain
Copy link
Member

Thanks!

@achingbrain achingbrain merged commit be025c8 into ipfs:master Jun 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants