Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

Module list #385

Merged
merged 1 commit into from
Aug 3, 2016
Merged

Module list #385

merged 1 commit into from
Aug 3, 2016

Conversation

dignifiedquire
Copy link
Member

@dignifiedquire dignifiedquire commented Jul 31, 2016

Based on the ideas in #271 and the list from @nginnever I made this package listing.

Closes #271

@diasdavid please review :)

@dignifiedquire dignifiedquire force-pushed the module-list branch 2 times, most recently from dd06dac to bbc9a89 Compare July 31, 2016 20:59
@daviddias
Copy link
Member

Thank you, this looks great! 👏

I see some of the badges are broken:

image

And I would prefer that the libp2p are in libp2p (because they eventually will too and then we need to update two places, which is cumbersome)

Plus, do we need to have devdependencies badge? What about having the CI instead?

@dignifiedquire
Copy link
Member Author

Plus, do we need to have devdependencies badge? What about having the CI instead?

We can do CI instead, or in addition. This is just based on cycle.js and babel which do this in this way already.

@dignifiedquire
Copy link
Member Author

And I would prefer that the libp2p are in libp2p (because they eventually will too and then we need to update two places, which is cumbersome)

Sure we can add a link here to those packages so it's easy to see.

@dignifiedquire
Copy link
Member Author

dignifiedquire commented Aug 1, 2016

I see some of the badges are broken:

all good for me, probably your internetz

screen shot 2016-08-01 at 15 13 33

@daviddias
Copy link
Member

@dignifiedquire try to refresh the badges, some of them point to /diasdavid/ repos, which I think is the cause why I don't see them. As for the rest 👍

dignifiedquire added a commit to libp2p/js-libp2p that referenced this pull request Aug 1, 2016
@dignifiedquire
Copy link
Member Author

@RichardLitt
Copy link
Member

We could use an array of packages and do something similar to project-repos.ipfs.io with these, as well. That would remove the necessity to redo the work there, and would allow keeping it up to date easier, I think.

@dignifiedquire
Copy link
Member Author

@RichardLitt I don't see how we can get a markdown table from an array in here, could you explain?

@RichardLitt
Copy link
Member

I'm saying we could specify an array of modules, from anywhere, as things that we want to feed into a variable instance of project-repos.ipfs.io. That way, instead of just seeing IPFS repos, you could switch it to also see the list of js-ipfs submodules. We need to make ipfs/project-repos extensible, anyway, to make sure it works with multiformats and libp2p repositories. cc @harlantwood

@daviddias
Copy link
Member

@RichardLitt could you open an issue in ipfs/community with that proposal, it looks that is something broader, that it will take more time and affect more projects.

@dignifiedquire let's move the "Packages" to right before "Contribute", the list is going to continue growing and we don't want to hide the architecture and descriptions. Also, s/Packages/Modules

Thank you!

@dignifiedquire
Copy link
Member Author

Also, s/Packages/Modules

why?

@dignifiedquire
Copy link
Member Author

let's move the "Packages" to right before "Contribute",

done

@daviddias daviddias merged commit cc5e584 into master Aug 3, 2016
@daviddias daviddias deleted the module-list branch August 3, 2016 17:22
@daviddias daviddias removed the status/in-progress In progress label Aug 3, 2016
MicrowaveDev pushed a commit to galtproject/js-ipfs that referenced this pull request May 22, 2020
* test: fix resolve test

1. This is an IPLD path.
2. Resolve really should be resolving up to the last path, not just "failing".

* fix: resolve test and add resolve across multiple test

License: MIT
Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants