Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

fix: align behaviour between go and js for content without paths #3385

Merged
merged 3 commits into from
Nov 12, 2020
Merged

fix: align behaviour between go and js for content without paths #3385

merged 3 commits into from
Nov 12, 2020

Commits on Nov 12, 2020

  1. fix: ensure correct progress is reported 

    Fixes a bug where due to parallel file imports, the reported size of
ingested bytes was getting mixed up.

We now tally imported bytes against the reported file name instead of
assuming a sequential import, taking care to not let the tally grow
until memory is exhausted.
    @achingbrain
    achingbrain committed Nov 12, 2020
    Configuration menu
    Copy the full SHA
    c4f2c7f View commit details
    Browse the repository at this point in the history

  2. chore: remove extra yield

    @achingbrain
    achingbrain committed Nov 12, 2020
    Configuration menu
    Copy the full SHA
    f98f400 View commit details
    Browse the repository at this point in the history

  3. fix: pass empty string as progress path when no path is present 

    Aligns behaviour between js and go when no path is present during an import
- we now pass an empty string instead of `'unknown'`.
    @achingbrain
    achingbrain committed Nov 12, 2020
    Configuration menu
    Copy the full SHA
    9b33e64 View commit details
    Browse the repository at this point in the history