fix `ipfs files add` CLI command. #312

hackergrrl · 2016-06-07T00:36:07Z

fixes 'files add' CLI to work with createAddStream changes
adds tests

daviddias · 2016-06-07T08:05:02Z

src/cli/commands/files/add.js

-          i.end()
-        }
+          i.once('end', () => {
+            return


shouldn't it be process.exit(0) ?

daviddias · 2016-06-07T08:08:22Z

Seems that there is a racing condition on add

https://travis-ci.org/ipfs/js-ipfs/jobs/135762823#L4512-L4516

      Uncaught AssertionError: expected 'QmZ25UfTqXGz9RsEJFg7HUAuBcmfx5dQZDXQd2QEZ8Kj74' to equal 'QmVvjDy7yF7hdnqE8Hrf4MHo5ABDtb5AbX6hWbD3Y42bXP'
      + expected - actual
      -QmZ25UfTqXGz9RsEJFg7HUAuBcmfx5dQZDXQd2QEZ8Kj74
      +QmVvjDy7yF7hdnqE8Hrf4MHo5ABDtb5AbX6hWbD3Y42bXP

That come from the tests generated earlier

daviddias · 2016-06-07T08:53:14Z

Also see #306 (comment), related to #312 (comment)

daviddias · 2016-06-07T09:35:38Z

Thank you :)

hackergrrl · 2016-06-07T15:37:01Z

Woah, fast merge! I didn't get to squash or address you comments. ;)

jbenet added the status/in-progress In progress label Jun 7, 2016

Implement ipfs.files.add CLI command.

1f13ac4

hackergrrl force-pushed the add-cli branch from 1538502 to 1f13ac4 Compare June 7, 2016 01:02

nit

f3fcc74

daviddias changed the title ~~Implement ipfs.files.add CLI command.~~ fix ipfs files add CLI command. Jun 7, 2016

daviddias reviewed Jun 7, 2016
View reviewed changes

src/cli/commands/files/add.js

i.end()

}

i.once('end', () => {

return

Copy link

Member

daviddias Jun 7, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't it be process.exit(0) ?

daviddias merged commit bf62c28 into ipfs:master Jun 7, 2016

jbenet removed the status/in-progress In progress label Jun 7, 2016

daviddias mentioned this pull request Jun 7, 2016

Fix racing condition on adding directories #315

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix `ipfs files add` CLI command. #312

fix `ipfs files add` CLI command. #312

hackergrrl commented Jun 7, 2016

daviddias Jun 7, 2016

daviddias commented Jun 7, 2016

daviddias commented Jun 7, 2016

daviddias commented Jun 7, 2016

hackergrrl commented Jun 7, 2016

fix ipfs files add CLI command. #312

fix ipfs files add CLI command. #312

Conversation

hackergrrl commented Jun 7, 2016

daviddias Jun 7, 2016

Choose a reason for hiding this comment

daviddias commented Jun 7, 2016

daviddias commented Jun 7, 2016

daviddias commented Jun 7, 2016

hackergrrl commented Jun 7, 2016

fix `ipfs files add` CLI command. #312

fix `ipfs files add` CLI command. #312