This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
refactor: replace ipfs.add in dag.get tests #2987
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is similar to other similar changes, we didn't start by implementing `ipfs.add` in `rust-ipfs`.
achingbrain
approved these changes
Apr 24, 2020
achingbrain
added a commit
that referenced
this pull request
Apr 24, 2020
Implements the same change as #2987 but using the unixfs-importer because go-ipfs does not support specifying CID versions to /block/put so the client has to create the CID and supply it.
|
This looks fine, but go-ipfs is missing a We can generate the CID on the client and send it to the block API though - I've added a second commit to #3005 which does this so it would supersede this PR. |
|
Fixed in #3005 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is similar to other similar changes, we didn't start by implementing
ipfs.addinrust-ipfs.Related PR's: #2972, #2980, #2982, #2983