This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
test: add repo-stat tests #2592
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achingbrain
suggested changes
Nov 7, 2019
There was a problem hiding this comment.
Also, can you make the commit line test: please. Turns out not everything is a chore, eh @alanshaw ?
See the commit types in ipfs/community/CONTRIBUTING_JS.md for more.
PedroMiguelSS
force-pushed
the
chore/add-repo-stat-tests
branch
from
0b364e0
to
24d7de6
Compare
|
@achingbrain commit line changed 👍 |
PedroMiguelSS
force-pushed
the
chore/add-repo-stat-tests
branch
from
9a5a871
to
6b06e0e
Compare
|
Can I get a second review here, please? @achingbrain @alanshaw @hugomrdias Please note that this PR depends on: |
achingbrain
suggested changes
Nov 14, 2019
achingbrain
suggested changes
Nov 14, 2019
PedroMiguelSS
force-pushed
the
chore/add-repo-stat-tests
branch
from
139080b
to
e7514de
Compare
1 task
|
Closed in favor of #2630. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tests for
repo-stat()and make theclioutput consistent withgo-ipfs.