Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

add ipld to validation config of options #2033

Merged
merged 3 commits into from
May 13, 2019

Conversation

MicrowaveDev
Copy link
Contributor

Fixes #2031

@alanshaw
Copy link
Member

Thanks @Jonybang. We should add a quick test to ensure this is working!

@MicrowaveDev MicrowaveDev reopened this May 10, 2019
@MicrowaveDev
Copy link
Contributor Author

I've fixed commit message, now CI should to pass

@MicrowaveDev
Copy link
Contributor Author

@alanshaw test like this?

@alanshaw
Copy link
Member

I don't think init takes ipld as an option.

If you add a test in https://github.com/ipfs/js-ipfs/blob/master/test/core/create-node.spec.js instead that does a new IPFS({ init: false, start: false, ipld: {} }) and checks that does not throw then we'd be all good!

@MicrowaveDev
Copy link
Contributor Author

@alanshaw now alright?

@alanshaw
Copy link
Member

That'll do 👌. Thanks @Jonybang, I'll wait for CI 🍏 and then get this merged.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError: Expected a value of type undefined for ipld but received {}.
2 participants