This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
chore: disable dht discovery #1907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
I did not add tests for the |
alanshaw
suggested changes
Mar 5, 2019
src/core/components/libp2p.js
Outdated
| @@ -79,7 +79,7 @@ function defaultBundle ({ datastore, peerInfo, peerBook, options, config }) { | |||
| kBucketSize: get(options, 'dht.kBucketSize', 20), | |||
| enabled: get(options, 'offline', false) ? false : undefined, // disable if offline | |||
| randomWalk: { | |||
| enabled: get(options, 'dht.randomWalk.enabled', true) | |||
| enabled: false | |||
There was a problem hiding this comment.
Please could you add a comment explaining the reason for this being disabled?
vasco-santos
force-pushed
the
chore/disable-dht-discovery
branch
from
d5f36ac
to
ceb9cd6
Compare
|
Thanks for pointing out Alan. Added the issue in a comment |
alanshaw
approved these changes
Mar 5, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
js-ipfswas having a bad time with CPU usage.In this context, we decided to go with a temporary change on
dht.put, as well as disabling therandom-walkdiscovery. We will benefit from discovery through the queries that we will be running for now.With this, we will get
js-ipfsstable again, as well as have the DHT available and have time to implement a proper solution to solve this issue.More details about the problem and discussion of the solution: