This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
test: make circuit relay test actually test circuit relay #1710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test: avoid running long circuit tests that will fail test: add check for addresses to circuit tests
ghost
assigned 
alanshaw
approved these changes
Nov 13, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The circuit relay test wasn't actually testing circuit relay, what fun!
ipfsd-ctlstill uses the experimental form of relay options, so it never gets turned on. I've switched relay over to be set via the libp2p options. I've also fixed the references to the nodes, they were wrong, which gave us the false sense of circuity-ness.Also, I moved the connect to
beforeso if the connect fails, we wont wait 80 seconds for the transfer to fail.