fix: fixing circuit-relaying example #1443
Conversation
|
@dryajov If you put "Fixes #1423" into the commit message body a la https://github.com/ipfs/community/blob/master/js-code-guidelines.md#examples, the corresponding issue gets closed automatically, once this PR lands :) Maybe you can update this commit? |
dryajov
force-pushed
the
fix/circuit-example
branch
from
3b343ec
to
bc9d41d
Compare
ghost
assigned 
|
thanks for the heads up @PascalPrecht |
| }, | ||
| "devDependencies": { | ||
| "aegir": "^14.0.0", | ||
| "http-server": "~0.10.0", |
There was a problem hiding this comment.
One thing though: Why exactly is this going to be removed? Maybe it shouldn't have been there in the first place, but I assume this has been put there for a reason and it doesn't seem to be necessary for this commit to do its work (fixing that example)
There was a problem hiding this comment.
It was missed. I left it there because the example was initially based on browserify and later moved to parcel.
|
@dryajov I left one more minor comment, sorry didn't catch this earlier. |
|
This LGTM then |
No description provided.