Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

Fixed issues with some required modules #108

Merged
merged 1 commit into from
Apr 4, 2016
Merged

Conversation

JGAntunes
Copy link
Member

While trying to install and run ipfs I ran into some troubles, this should fix some of it.

@jbenet jbenet added the backlog label Apr 3, 2016
@JGAntunes
Copy link
Member Author

It also seems to me that the current build is failing due to this - ipfs/js-ipfs-unixfs#8

@fbaiodias
Copy link
Member

LGTM

@@ -3,7 +3,7 @@ const debug = require('debug')
const path = require('path')
const log = debug('cli:config')
log.error = debug('cli:config:error')
const utils = require('utils')
const utils = require('../../utils')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how was this not failing before? Could you add a test too @JGAntunes ? Thank you!

//cc @xicombd

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No idea, I'll try to review the config commands later today, I think they're not working with the daemon running either 😟

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@diasdavid sure thing, will look at it later today also, so maybe I can help you out @xicombd.

@daviddias
Copy link
Member

build is green now (for this branch as well), let me know if it is working for you.

@JGAntunes
Copy link
Member Author

Seems good to me, I can now install and run the cli.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants