Pubsub message fields #1077
Pubsub message fields #1077
Conversation
|
@diasdavid Needs PR libp2p/js-libp2p-floodsub#49 and ipfs-inactive/interface-js-ipfs-core#169 released. Then update dependencies. |
ghost
assigned 
|
@richardschneider deps updated. Could you please add some interop pubsub tests to make sure both communicate well? |
|
It's not an easy test to create; which is most likely why no-one has written it yet. I'm solving other issues now. Perhaps create an issue and assign it to me. |
|
@richardschneider wrote the set up for you, all you have to do is |
|
will try to write interop test tomorrow |
|
@diasdavid Could you merge these changes. Then I can starting testing from a solid base. Cheers! |
| @@ -39,7 +40,7 @@ class GoDaemon { | |||
| this.node = node | |||
| this.node.setConfig('Bootstrap', '[]', cb) | |||
| }, | |||
| (res, cb) => this.node.startDaemon(cb), | |||
| (res, cb) => this.node.startDaemon(this.flags, cb), | |||
There was a problem hiding this comment.
@richardschneider this was causing all interop tests to fail.
Too much greenkeeper noise and they are not critical to the project.
msg.fromis base64 encoded in go-ipfsSee the background discussion.