Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

Encoding key names with base32 #1937

Closed
AuHau opened this issue Mar 14, 2019 · 3 comments
Closed

Encoding key names with base32 #1937

AuHau opened this issue Mar 14, 2019 · 3 comments

Comments

@AuHau
Copy link
Member

AuHau commented Mar 14, 2019

Type: Enhacement

Description:

As part of my PR ipfs/kubo#6012 go-ipfs will be encoding key's names into base32 in order to unify behavior across all platforms (case sensitivity). As a small bonus because of it, it will be able to use any characters for the key's names (like namespacing for example "websites/some-website").

I assume that since js-ipfs has a goal to have interoperable repositories with go-ipfs, this behavior should be propagated from go-ipfs to js-ipfs as well.

I am happy to provide PR for js-ipfs as well.

I have a few questions.
Is this desired from your side? Will you accept the PR?
My idea of implementation of it would be to create something like EncodedDatastore wrapper that would be used in js-ipfs-repo for the keys property and would do the translation from/to base32.
I believe the base32 encoding won't be necessary for the datastore-level, should I hardwire exception for it or also encode it?

@alanshaw
Copy link
Member

@AuHau would this need #1115 to be implemented first?

@AuHau
Copy link
Member Author

AuHau commented Mar 15, 2019

Yeah, definitely.

But I am actually working on migration tool here: https://github.com/AuHau/js-ipfs-repo-migrations and this will be first demonstration migration. Hopefully next week I should have first version for review.

@whizzzkid
Copy link

js-ipfs is being deprecated in favor of Helia. You can #4336 and read the migration guide.

Please feel to reopen with any comments before 2023-06-05. We will do a final pass on reopened issues afterward (see #4336).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants