Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

Support exposing API/Gateway on multiple multiaddrs #1852

Closed
lidel opened this issue Jan 29, 2019 · 4 comments · Fixed by #1903
Closed

Support exposing API/Gateway on multiple multiaddrs #1852

lidel opened this issue Jan 29, 2019 · 4 comments · Fixed by #1903
Labels
exp/novice Someone with a little familiarity can pick up help wanted Seeking public contribution on this issue P3 Low: Not priority right now

Comments

@lidel
Copy link
Member

lidel commented Jan 29, 2019

go-ipfs supports listening on multiple multiaddrs if an array is provided instead of a single multiaddr.

Both snippets are valid in go-ipfs:

ipv4+ipv6

	"Addresses": {
		"API": [
			"/ip4/127.0.0.1/tcp/5002",
			"/ip6/::1/tcp/5002"
		],
		"Gateway": [
			"/ip4/127.0.0.1/tcp/9090",
			"/ip6/::1/tcp/9090"
		],

ipv4 only

	"Addresses": {
		"API": "/ip4/127.0.0.1/tcp/5002",
		"Gateway": "/ip4/127.0.0.1/tcp/9090",

Unfortunately js-ipfs does not support arrays, only a single address can be defined ATM.

cc #1563, ipfs/kubo#5905

@alanshaw alanshaw added exp/novice Someone with a little familiarity can pick up help wanted Seeking public contribution on this issue status/ready Ready to be worked P3 Low: Not priority right now labels Jan 30, 2019
@grantlouisherman
Copy link
Contributor

grantlouisherman commented Feb 4, 2019

Hello @lidel @alanshaw is it still possible for me to take a look at this? Not sure if this was already handled.

@alanshaw
Copy link
Member

alanshaw commented Feb 6, 2019

@grantlouisherman YES ❤️ it would be awesome if you'd like to take this on. Please ping me if you need any pointers.

@grantlouisherman
Copy link
Contributor

hey @alanshaw PR is here #1903

@grantlouisherman
Copy link
Contributor

hey @alanshaw could you assign someone to that PR whenever it is prudent. I just need some help with the test cases.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
exp/novice Someone with a little familiarity can pick up help wanted Seeking public contribution on this issue P3 Low: Not priority right now
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants