Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

Disable preloading in test environments #1815

Closed
alanshaw opened this issue Jan 14, 2019 · 0 comments · Fixed by #2194
Closed

Disable preloading in test environments #1815

alanshaw opened this issue Jan 14, 2019 · 0 comments · Fixed by #2194
Assignees
@alanshaw
Labels
exp/novice Someone with a little familiarity can pick up help wanted Seeking public contribution on this issue P2 Medium: Good to have, but can wait until someone steps up status/in-progress In progress

Comments

@alanshaw
Copy link
Member

For all tests other than the ones testing preloading we should disable preloading. We can detect a CI environment variable and default the preload option to false if not explicitly set.
@alanshaw alanshaw added exp/novice Someone with a little familiarity can pick up help wanted Seeking public contribution on this issue status/ready Ready to be worked P2 Medium: Good to have, but can wait until someone steps up labels Jan 14, 2019
alanshaw pushed a commit that referenced this issue Jan 15, 2019
feat: disable preload by default in test/CI environments
a5a6c54 
resolves #1815

License: MIT
Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
@alanshaw alanshaw mentioned this issue Jan 15, 2019
Closed
@ghost ghost assigned alanshaw Jan 15, 2019
@ghost ghost added status/in-progress In progress and removed status/ready Ready to be worked labels Jan 15, 2019
alanshaw pushed a commit that referenced this issue Jan 15, 2019
feat: disable preload by default in test/CI environments
cd1d53a 
resolves #1815

License: MIT
Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
@alanshaw alanshaw mentioned this issue Jun 24, 2019
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alanshaw alanshaw

Labels
exp/novice Someone with a little familiarity can pick up help wanted Seeking public contribution on this issue P2 Medium: Good to have, but can wait until someone steps up status/in-progress In progress
Projects
None yet
Milestone
No milestone
1 participant
@alanshaw