Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

agentVersion #1080

Closed
richardschneider opened this issue Nov 16, 2017 · 1 comment
Closed

agentVersion #1080

richardschneider opened this issue Nov 16, 2017 · 1 comment
Assignees
@richardschneider

Comments

@richardschneider
Copy link
Contributor

The agentVersion does not contain the version number.

Should be js-ipfs/x.x.x

node src\cli\bin.js id

{
  "id": "QmYJ5Cm2dBEdDmCYkSqGoCViFfu3BE3xN8gJydMdtoVsdP",
  "publicKey": "CAASpgIwggEiMA0GCSqGSIb3DQEBAQUAA4IBDwAwggEKAoIBAQClAYbZxoIy9l13U6KgWGjasEUQnytv0HSoosk2++oqLeIfpq68Xf7vTjYm8Lmx1t04LbpUg6WZN9gLA7vN24AUzybSulDSKM+mZJOsvi+IQDcnRn3FCybgIX+yj4hvs3M9wiSdUEhLnBszPQuLPOfLI66Z6pEsaw1Etb9JAu+WXgQZp561pWlAAcVL9i6Jftn6gO6yZriG4G5eqpZq9el8dIFnevUeYrvCr6vRRgIlqFrb3UQA/pTS/1RWY6rctxEWzcSAnFMt/KXa9DiRbmF3dES+XuQkiIJMgCJb/uV+qrSzv3jZTMDNHBu1ScjxOkiR6B0IziPWgNtz6nT/jqY/AgMBAAE=",
  "addresses": [],
  "agentVersion": "js-ipfs",
  "protocolVersion": "9000"
}
@daviddias daviddias changed the title 'jsipfs id' agentVersion Nov 17, 2017
@daviddias
Copy link
Member

Happy to take a PR that adds that

@richardschneider richardschneider self-assigned this Dec 1, 2017
richardschneider added a commit that referenced this issue Dec 1, 2017
@richardschneider
fix: add package version number to the agent version #1080
bd5e2f8
@richardschneider richardschneider mentioned this issue Dec 1, 2017
Merged
daviddias pushed a commit that referenced this issue Dec 1, 2017
@richardschneider @daviddias
feat: agent version with package number (#1121)
550f955 
* fix: add package version number to the agent version  #1080

* test: adjust for new agent version
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@richardschneider richardschneider

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@richardschneider @daviddias