fix: do not destructure node callback results

ipfs · Jun 18, 2018 · d0b4a0c · d0b4a0c
1 parent a7a55b9
commit d0b4a0c
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 6 deletions.
diff --git a/src/core/components/dag.js b/src/core/components/dag.js
@@ -39,7 +39,7 @@ module.exports = function dag (self) {
         try {
           cid = new CID(cid)
         } catch (err) {
-          callback(err)
+          return callback(err)
         }
       }
 

diff --git a/src/core/components/pin-set.js b/src/core/components/pin-set.js
@@ -74,9 +74,9 @@ exports = module.exports = function (dag) {
 
           seen[bs58Link] = true
 
-          dag.get(multihash, (err, { value }) => {
+          dag.get(multihash, (err, res) => {
             if (err) { return someCb(err) }
-            searchChildren(value, someCb)
+            searchChildren(res.value, someCb)
           })
         }, cb)
       }

diff --git a/src/core/components/pin.js b/src/core/components/pin.js
@@ -157,7 +157,7 @@ module.exports = function pin (self) {
           // persist updated pin sets to datastore
           flushPins((err, root) => {
             if (err) { return callback(err) }
-            return callback(null, results.map(key => ({hash: key})))
+            return callback(null, results.map(hash => ({ hash })))
           })
         })
       })
@@ -215,7 +215,7 @@ module.exports = function pin (self) {
           flushPins((err, root) => {
             if (err) { return callback(err) }
             self.log(`Removed pins: ${results}`)
-            return callback(null, results.map(key => ({hash: key})))
+            return callback(null, results.map(hash => ({ hash })))
           })
         })
       })
@@ -375,8 +375,9 @@ module.exports = function pin (self) {
         async.parallel([
           cb => pinset.loadSet(pinRoot.value, types.recursive, cb),
           cb => pinset.loadSet(pinRoot.value, types.direct, cb)
-        ], (err, [rKeys, dKeys]) => {
+        ], (err, keys) => {
           if (err) { return callback(err) }
+          const [ rKeys, dKeys ] = keys
 
           directPins = new Set(dKeys.map(toB58String))
           recursivePins = new Set(rKeys.map(toB58String))