feat: agent version with package number (#1121)

* fix: add package version number to the agent version #1080 * test: adjust for new agent version
ipfs · Dec 1, 2017 · 550f955 · 550f955
1 parent 9eda8a8
commit 550f955
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 3 deletions.
diff --git a/src/core/components/id.js b/src/core/components/id.js
@@ -2,6 +2,7 @@
 
 const promisify = require('promisify-es6')
 const setImmediate = require('async/setImmediate')
+const pkgversion = require('../../../package.json').version
 
 module.exports = function id (self) {
   return promisify((opts, callback) => {
@@ -18,7 +19,7 @@ module.exports = function id (self) {
         .map((ma) => ma.toString())
         .filter((ma) => ma.indexOf('ipfs') >= 0)
         .sort(),
-      agentVersion: 'js-ipfs',
+      agentVersion: `js-ipfs/${pkgversion}`,
       protocolVersion: '9000'
     }))
   })

diff --git a/test/http-api/extra/id.js b/test/http-api/extra/id.js
@@ -13,7 +13,9 @@ module.exports = (ctl) => {
         expect(err).to.not.exist()
         expect(result.id).to.equal(idResult.ID)
         expect(result.publicKey).to.equal(idResult.PublicKey)
-        expect(result.agentVersion).to.equal(idResult.AgentVersion)
+        const agentComponents = result.agentVersion.split('/')
+        expect(agentComponents).lengthOf.above(1)
+        expect(agentComponents[0]).to.equal(idResult.AgentVersion)
         expect(result.protocolVersion).to.equal(idResult.ProtocolVersion)
         done()
       })

diff --git a/test/http-api/spec/id.js b/test/http-api/spec/id.js
@@ -18,7 +18,9 @@ module.exports = (http) => {
       }, (res) => {
         expect(res.result.ID).to.equal(idResult.ID)
         expect(res.result.PublicKey).to.equal(idResult.PublicKey)
-        expect(res.result.AgentVersion).to.equal(idResult.AgentVersion)
+        const agentComponents = res.result.AgentVersion.split('/')
+        expect(agentComponents).lengthOf.above(1)
+        expect(agentComponents[0]).to.equal(idResult.AgentVersion)
         expect(res.result.ProtocolVersion).to.equal(idResult.ProtocolVersion)
         done()
       })