fix: only dial to unconnected peers (#1914)

* fix: only dial to unconnected peers

License: MIT
Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>

* fix: update peer info before conditionally dialing

When we discover a peer, we may not have the latest information from our PeerBook, such as the connected multiaddress. Doing peerBook.put handles merging this information and the new PeerInfo instance is returned. Updating the peerInfo instance, before performing a check, should make sure we have the correct information.

Co-Authored-By: alanshaw <alan.shaw@protocol.ai>

* refactor: share noop callback

License: MIT
Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>

src/core/components/libp2p.js

@@ -19,9 +19,12 @@ module.exports = function libp2p (self, config) {
   const libp2p = createBundle({ options, config, datastore, peerInfo, peerBook })
   let discoveredPeers = []
 
+  const noop = () => {}
   const putAndDial = peerInfo => {
-    peerBook.put(peerInfo)
-    libp2p.dial(peerInfo, () => {})
+    peerInfo = peerBook.put(peerInfo)
+    if (!peerInfo.isConnected()) {
+      libp2p.dial(peerInfo, noop)
+    }
   }
 
   libp2p.on('start', () => {