fix: add cross-impl shard test, fix path cleaner #358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanshaw
reviewed
Aug 25, 2023
rvagg
force-pushed
the
rvagg/fanout-tests
branch
2 times, most recently
from
570dae3
to
c5ff577
Compare
rvagg
commented
Aug 25, 2023
| .trim() | ||
| .match(/([^\\/]|\\\/)+/g) ?? []) | ||
| .filter(Boolean) | ||
| return path.split(/(?<!\\)\//).filter(Boolean) |
There was a problem hiding this comment.
it's also a little odd to escape \ here because we don't do that elsewhere in ipfs-land, paths officially have no escaping mechanism but 🤷
rvagg
force-pushed
the
rvagg/fanout-tests
branch
from
c5ff577
to
b0ef506
Compare
alanshaw
approved these changes
Aug 25, 2023
achingbrain
approved these changes
Aug 25, 2023
|
Thanks! |
github-actions bot
pushed a commit
that referenced
this pull request
Aug 25, 2023
## [ipfs-unixfs-importer-v15.2.1](ipfs-unixfs-importer-v15.2.0...ipfs-unixfs-importer-v15.2.1) (2023-08-25) ### Bug Fixes * add cross-impl shard test, fix path cleaner ([#358](#358)) ([00293b3](00293b3))
github-actions bot
pushed a commit
that referenced
this pull request
Aug 25, 2023
## [ipfs-unixfs-exporter-v13.2.1](ipfs-unixfs-exporter-v13.2.0...ipfs-unixfs-exporter-v13.2.1) (2023-08-25) ### Bug Fixes * add cross-impl shard test, fix path cleaner ([#358](#358)) ([00293b3](00293b3))
rvagg
added a commit
to ipfs/go-unixfsnode
that referenced
this pull request
Aug 25, 2023
rvagg
added a commit
to ipfs/go-unixfsnode
that referenced
this pull request
Aug 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: ipfs/go-unixfsnode#66
The material change in here is the path cleaner/splitter; it's a bit too aggressive. It doesn't allow
\as a file name and the.trim()discounts valid file names. Otherwise this is a match for ipfs/go-unixfsnode#66 and gets the same CID on importer, and tests the exporter can read the same data.