Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic repo migrations #202

Merged
merged 11 commits into from
Nov 6, 2019
Merged

Automatic repo migrations #202

merged 11 commits into from
Nov 6, 2019

Conversation

AuHau
Copy link
Member

@AuHau AuHau commented Jun 28, 2019

This PR brings integration of js-ipfs-repo-migrations brings automatic repo migrations to ipfs-repo (both in-browser and fs). It is possible to control the automatic migration using either config's setting 'repoDisableAutoMigration' or IPFSRepo's option 'disableAutoMigration'.

Related PRs: js-ipfs, js-ipfs-repo-migrations

Questions to tackle:

  • should throw err when version is higher then expected? (currently only log)
  • repo.version.check() change of behaviour (throw ==> bool)

package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
src/default-options-browser.js Outdated Show resolved Hide resolved
src/index.js Outdated Show resolved Hide resolved
src/index.js Outdated Show resolved Hide resolved
src/index.js Outdated Show resolved Hide resolved
src/index.js Outdated Show resolved Hide resolved
src/index.js Show resolved Hide resolved
@AuHau AuHau changed the title Automatic repo migrations [WIP] Automatic repo migrations Jul 23, 2019
@AuHau AuHau changed the title [WIP] Automatic repo migrations Automatic repo migrations Oct 9, 2019
Copy link
Member

@daviddias daviddias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, just some nitpicks and a nice to have.

package.json Outdated Show resolved Hide resolved
src/index.js Show resolved Hide resolved
src/index.js Show resolved Hide resolved
test/node.js Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
src/errors/index.js Outdated Show resolved Hide resolved
src/errors/index.js Outdated Show resolved Hide resolved
src/index.js Outdated Show resolved Hide resolved
test/node.js Outdated Show resolved Hide resolved
test/node.js Outdated Show resolved Hide resolved
test/node.js Outdated Show resolved Hide resolved
@alanshaw
Copy link
Member

alanshaw commented Nov 4, 2019

ping @AuHau

@AuHau
Copy link
Member Author

AuHau commented Nov 4, 2019

Sorry, got a job now, so it might take some time to get back to this. Hopefully in the following days.

Integration of js-ipfs-repo-migrations brings automatic repo migrations
to ipfs-repo (both in-browser and fs). It is possible to control the
automatic migration using either config's setting
'repoDisableAutoMigration' or IPFSRepo's option 'disableAutoMigration'.

License: MIT
Signed-off-by: Adam Uhlir <adam@uhlir.dev>
License: MIT
Signed-off-by: Adam Uhlir <adam@uhlir.dev>
License: MIT
Signed-off-by: Adam Uhlir <adam@uhlir.dev>
@AuHau AuHau force-pushed the feat/repo-migrations branch 2 times, most recently from 40dc006 to 2d21166 Compare November 6, 2019 10:24
@AuHau
Copy link
Member Author

AuHau commented Nov 6, 2019

I believe this is ready to be merged.
js-ipfs-repo-migrations is released and updated here.

@alanshaw
Copy link
Member

alanshaw commented Nov 6, 2019

@jacobheun please can we have review+merge+release?

@jacobheun
Copy link
Contributor

@alanshaw on it!

Copy link
Contributor

@jacobheun jacobheun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🎉

@jacobheun jacobheun merged commit a0b6f95 into master Nov 6, 2019
@jacobheun jacobheun deleted the feat/repo-migrations branch November 6, 2019 12:10
@jacobheun
Copy link
Contributor

0.29 is out! 🚀

alanshaw pushed a commit to ipfs/js-ipfs that referenced this pull request Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants