fix: upgrade datastores for node 10 #168
Conversation
move the responsibility of levelup browser support to datastore-level License: MIT Signed-off-by: Jacob Heun <jacobheun@gmail.com>
ghost
assigned License: MIT Signed-off-by: Jacob Heun <jacobheun@gmail.com> chore: use 10.0 instead of 10.1 License: MIT Signed-off-by: Jacob Heun <jacobheun@gmail.com>
License: MIT Signed-off-by: Jacob Heun <jacobheun@gmail.com>
License: MIT Signed-off-by: Jacob Heun <jacobheun@gmail.com>
License: MIT Signed-off-by: Jacob Heun <jacobheun@gmail.com>
package.json
Outdated
| "datastore-fs": "~0.4.2", | ||
| "datastore-level": "~0.7.0", | ||
| "datastore-fs": "github:ipfs/js-datastore-fs#fix/node10", | ||
| "datastore-level": "github:ipfs/js-datastore-level#fix/node10", |
There was a problem hiding this comment.
Note to self: needs ipfs/js-datastore-level#7
package.json
Outdated
| @@ -59,14 +58,12 @@ | |||
| "big.js": "^5.0.3", | |||
| "cids": "~0.5.3", | |||
| "datastore-core": "~0.4.0", | |||
| "datastore-fs": "~0.4.2", | |||
| "datastore-level": "~0.7.0", | |||
| "datastore-fs": "github:ipfs/js-datastore-fs#fix/node10", | |||
There was a problem hiding this comment.
This has been merged and released, the dep can be updated.
package.json
Outdated
| "level-js": "timkuijsten/level.js#idbunwrapper", | ||
| "leveldown": "^1.7.2", | ||
| "lock-me": "^1.0.3", | ||
| "lock-me": "github:jacobheun/lock-me#fix/windows", |
There was a problem hiding this comment.
Can we get this PR up so that @dignifiedquire can review and merge?
There was a problem hiding this comment.
We've already gotten that merged and released with lock-me 1.0.4.
datastore-level is the only thing left to be merged, and then I will update all the deps for this. I will get the feedback for that resolved so we can get it merged in.
|
@jacobheun has this been tested against latest js-ipfs? |
|
@diasdavid yes, this branch was used against the js-ipfs updates and passing ci tests, ipfs/js-ipfs#1358, as well as locally. It should be ready for release. |
This fixes an issue where node 10 builds are failing due to old versions of level. They have been upgraded in datastore-level.
This PR also moves the responsibility of shimming leveldown in the browser to
datastore-leveldepends on ipfs/js-datastore-level#7
depends on ipfs/js-datastore-fs#16
depends on dignifiedquire/lock-me#3
resolves #167
connects to ipfs/js-ipfs#1347