Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/windows #3

Merged
merged 2 commits into from
May 22, 2018
Merged

Fix/windows #3

merged 2 commits into from
May 22, 2018

Conversation

jacobheun
Copy link
Contributor

There is an issue in node 10 where an extra, undefined value is being passed into the fs callbacks. This causes the async methods to fail.

I found the issue on a jenkins build of windows for js-ipfs. I added windows and node 10 to the travis file for this repo to verify the failure, and then added the fix.

You can see the failure on my fork here with windows node 10 added to travis.
And the fixed build here.

@jacobheun jacobheun mentioned this pull request May 21, 2018
10 tasks
@codecov-io
Copy link

codecov-io commented May 21, 2018

Codecov Report

Merging #3 into master will decrease coverage by 0.66%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #3      +/-   ##
==========================================
- Coverage   64.58%   63.91%   -0.67%     
==========================================
  Files           3        3              
  Lines          96       97       +1     
==========================================
  Hits           62       62              
- Misses         34       35       +1
Impacted Files Coverage Δ
src/portable.js 34.78% <33.33%> (-0.78%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e23543...4347c3c. Read the comment docs.

@dignifiedquire dignifiedquire merged commit c707262 into dignifiedquire:master May 22, 2018
@dignifiedquire
Copy link
Owner

Thank you

@dignifiedquire
Copy link
Owner

published new version

@jacobheun jacobheun deleted the fix/windows branch May 22, 2018 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants