This repository has been archived by the owner on Mar 23, 2023. It is now read-only.
feat: add basic error codes and update test #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
License: MIT Signed-off-by: Jacob Heun <jacobheun@gmail.com>
ghost
assigned 
jacobheun
changed the title
License: MIT Signed-off-by: Jacob Heun <jacobheun@gmail.com>
License: MIT Signed-off-by: Jacob Heun <jacobheun@gmail.com>
License: MIT Signed-off-by: Jacob Heun <jacobheun@gmail.com>
License: MIT Signed-off-by: Jacob Heun <jacobheun@gmail.com>
jacobheun
force-pushed
the
feat/err-codes
branch
from
d5bce30
to
e7893b5
Compare
vasco-santos
suggested changes
Sep 20, 2018
vasco-santos
approved these changes
Sep 20, 2018
|
Thanks @vasco-santos, I will wait to merge this after the js-ipfs updates are released as the example will fail until that's done. |
License: MIT Signed-off-by: Jacob Heun <jacobheun@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on ipfs/interface-datastore#22
Related to ipfs/js-ipfs#1557
This PR adds consistent error codes from the interface-datastore to allow downstream code to consistently handle datastore errors.