This repository has been archived by the owner on Mar 23, 2023. It is now read-only.
chore: upgrade dependencies #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
alanshaw
approved these changes
Oct 24, 2018
jacobheun
suggested changes
Oct 24, 2018
There was a problem hiding this comment.
@vasco-santos can you take a look at the failing tests? It looks like the expect array equivalency check may just need to get updated.
|
@jacobheun The arrays seem equal. The only difference between the versions are the Master version:
PR version:
|
|
thanks for discovering the issue @jacobheun Can you approve the PR now? |
jacobheun
approved these changes
Oct 25, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade dependencies in the context of js-ipfs/pull/1617