Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update desktop language #1839

Merged
merged 1 commit into from
Sep 1, 2021
Merged

fix: update desktop language #1839

merged 1 commit into from
Sep 1, 2021

Conversation

hacdias
Copy link
Member

@hacdias hacdias commented Aug 19, 2021

Goes with ipfs/ipfs-desktop#1894.

I think language switching wasn't even working at all because we're not using the localStorage anymore and IPFS Desktop simply had a wrapper around the localStorage.setItem function. Now it's more explicit and does not have room for many mistakes.

License: MIT
Signed-off-by: Henrique Dias hacdias@gmail.com

License: MIT
Signed-off-by: Henrique Dias <hacdias@gmail.com>
@hacdias hacdias self-assigned this Aug 19, 2021
@hacdias hacdias temporarily deployed to Deploy August 19, 2021 07:28 Inactive
Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lidel lidel merged commit b2e6208 into main Sep 1, 2021
@lidel lidel deleted the fix/context-desktop branch September 1, 2021 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants