fix(line-wrap): Fixed tooltips of file names #1709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Set break-word property to tooltip. - Changed overflow of rows to visible. - Set tooltip width to not exceed the menus width. Fixes: ipfs#1464
|
Hi @melegiul -- thank you so much for fixing something that's been one of my own pet peeves! ;) Confirmed to work as intended on Mac (Big Sur) in latest Chrome, Brave, Safari, Firefox: Long file name (Chrome): CID on narrow screen (Chrome): Note that Safari has always displayed these differently: Also note that this does not address the issue with hover text clipping on the last item in a files list due to the react-virtualized grid acting as a boundary, but that's not within the scope of this issue. I'm marking this PR as LGTM, but asking @lidel to have a quick look before we merge. Thanks again! |
jessicaschilling
approved these changes
Jan 11, 2021
lidel
approved these changes
Jan 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the problem of displaying long file names when hovering the file.
Fixes: #1464
Screenshot