Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add visual feedback on API address change #1671

Merged
merged 28 commits into from
Oct 29, 2020
Merged

feat: add visual feedback on API address change #1671

merged 28 commits into from
Oct 29, 2020

Commits on Oct 14, 2020

  1. Add error text to API address settings

    @jack-michaud
    jack-michaud committed Oct 14, 2020
    Configuration menu
    Copy the full SHA
    23d5f3f View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2020

  1. Populate error message for invalid addresses and connection errors

    @jack-michaud
    jack-michaud committed Oct 15, 2020
    Configuration menu
    Copy the full SHA
    7d56569 View commit details
    Browse the repository at this point in the history

  2. Add outline to ApiAddressForm to indicate address validity

    @jack-michaud
    jack-michaud committed Oct 15, 2020
    Configuration menu
    Copy the full SHA
    6268c09 View commit details
    Browse the repository at this point in the history

  3. Add apiAddress to "could not connect" message

    @jack-michaud
    jack-michaud committed Oct 15, 2020
    Configuration menu
    Copy the full SHA
    ff59fd5 View commit details
    Browse the repository at this point in the history

  4. Add "pending first API connection" handlers to ipfs-provider

    @jack-michaud
    jack-michaud committed Oct 15, 2020
    Configuration menu
    Copy the full SHA
    d4a4456 View commit details
    Browse the repository at this point in the history

  5. Add full page loader when pending first connection

    @jack-michaud
    jack-michaud committed Oct 15, 2020
    Configuration menu
    Copy the full SHA
    4a89afd View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2020

  1. Remove custom error CSS, instead use Notify for errors

    @jack-michaud
    jack-michaud committed Oct 18, 2020
    Configuration menu
    Copy the full SHA
    01d3cf2 View commit details
    Browse the repository at this point in the history

  2. Feedback from @rafaelramalho19 - Use arrow function

    @jack-michaud
    jack-michaud committed Oct 18, 2020
    Configuration menu
    Copy the full SHA
    7483a73 View commit details
    Browse the repository at this point in the history

  3. Feedback from @jessicashilling and @rafaelramalho19 

    - Use notify/snackbar for errors and success messages.
- Use notify error message that have translations
    @jack-michaud
    jack-michaud committed Oct 18, 2020
    Configuration menu
    Copy the full SHA
    9c46977 View commit details
    Browse the repository at this point in the history

  4. Remove connectionError action in ipfs-provider. 

    Opt to use notify instead
    @jack-michaud
    jack-michaud committed Oct 18, 2020
    Configuration menu
    Copy the full SHA
    1cddd15 View commit details
    Browse the repository at this point in the history

  5. Remove unused icon, comment

    @jack-michaud
    jack-michaud committed Oct 18, 2020
    Configuration menu
    Copy the full SHA
    58b0f3c View commit details
    Browse the repository at this point in the history

  6. Fix bug that shows success message before updating API address

    @jack-michaud
    jack-michaud committed Oct 18, 2020
    Configuration menu
    Copy the full SHA
    ebd2af5 View commit details
    Browse the repository at this point in the history

  7. Fix formatting

    @jack-michaud
    jack-michaud committed Oct 18, 2020
    Configuration menu
    Copy the full SHA
    d88fb5a View commit details
    Browse the repository at this point in the history

  8. Remove unused "dispatch"

    @jack-michaud
    jack-michaud committed Oct 18, 2020
    Configuration menu
    Copy the full SHA
    80f86f9 View commit details
    Browse the repository at this point in the history

  9. Add custom error messages for connecting to a new IPFS API

    @jack-michaud
    jack-michaud committed Oct 18, 2020
    Configuration menu
    Copy the full SHA
    e3dbde0 View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2020

  1. IPFS_CONNECT_SUCCEED/FAILED set fail state in ipfs-provider

    @jack-michaud
    jack-michaud committed Oct 19, 2020
    Configuration menu
    Copy the full SHA
    2cf8a47 View commit details
    Browse the repository at this point in the history

  2. Return result of API address update in doUpdateIpfsApiAddress

    @jack-michaud
    jack-michaud committed Oct 19, 2020
    Configuration menu
    Copy the full SHA
    da320ed View commit details
    Browse the repository at this point in the history

  3. Add ipfsInvalidApiAddress to locales/en/notify.json and notify.js

    @jack-michaud
    jack-michaud committed Oct 19, 2020
    Configuration menu
    Copy the full SHA
    4bf7436 View commit details
    Browse the repository at this point in the history

  4. Refocus on input if the API address failed to update

    @jack-michaud
    jack-michaud committed Oct 19, 2020
    Configuration menu
    Copy the full SHA
    c330e50 View commit details
    Browse the repository at this point in the history

  5. Show green/red border for valid/invalid API address or red border for… 

    … invalid api address
    @jack-michaud
    jack-michaud committed Oct 19, 2020
    Configuration menu
    Copy the full SHA
    10d2fb0 View commit details
    Browse the repository at this point in the history

  6. Change ApiAddressForm to more closely follow SelectPeer 

    - Shows fail/success border without being selected
- Does not refocus if it fails to connect
    @jack-michaud
    jack-michaud committed Oct 19, 2020
    Configuration menu
    Copy the full SHA
    2746ae8 View commit details
    Browse the repository at this point in the history

  7. Clean up unused code and comments

    @jack-michaud
    jack-michaud committed Oct 19, 2020
    Configuration menu
    Copy the full SHA
    31d53de View commit details
    Browse the repository at this point in the history

  8. Update comments

    @jack-michaud
    jack-michaud committed Oct 19, 2020
    Configuration menu
    Copy the full SHA
    038cbc8 View commit details
    Browse the repository at this point in the history

  9. Remove useRef from imports

    @jack-michaud
    jack-michaud committed Oct 19, 2020
    Configuration menu
    Copy the full SHA
    34a1c0a View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2020

  1. Disables button with an invalid multiaddr and display red border when 

    it fails to connect.
When entering in another address, it will refresh the fail state on the
input
    @jack-michaud
    jack-michaud committed Oct 20, 2020
    Configuration menu
    Copy the full SHA
    e3a41ad View commit details
    Browse the repository at this point in the history

  2. Follow formatting

    @jack-michaud
    jack-michaud committed Oct 20, 2020
    Configuration menu
    Copy the full SHA
    daef34f View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2020

  1. Merge branch 'master' of github.com:ipfs-shipyard/ipfs-webui into fea… 

    …ture/api-address-status
    @jack-michaud
    jack-michaud committed Oct 28, 2020
    Configuration menu
    Copy the full SHA
    4954294 View commit details
    Browse the repository at this point in the history

  2. Feedback from @rafaelramalho19 

    - Use triple equals
    @jack-michaud
    jack-michaud committed Oct 28, 2020
    Configuration menu
    Copy the full SHA
    67a4173 View commit details
    Browse the repository at this point in the history