Added a log #160
Merged
Added a log #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -30,7 +30,9 @@ function doOperation (op) { | |||
| if (op === 'getItem') { | |||
| try { | |||
| result = JSON.parse(result) | |||
| } catch (e) {} | |||
| } catch (e) { | |||
| console.log('LocalStorage error: Unable to parse result as json. Message: ' + e.message) | |||
There was a problem hiding this comment.
Please use debug for logging
RichardLitt
force-pushed
the
feature/add-log
branch
from
07ba93c
to
5a4fb8b
Compare
|
How does this look? |
| @@ -1,4 +1,7 @@ | |||
| import _ from 'lodash' | |||
| import Debug from 'debug' | |||
|
|
|||
| const debug = Debug('ipfs:utils:LocalStorage') | |||
There was a problem hiding this comment.
Can we use the convention I have in #155, i.e.
import debug from 'debug'
const log = debug('utils:localStorage')
RichardLitt
force-pushed
the
feature/add-log
branch
from
5a4fb8b
to
177d031
Compare
|
Sure. I got that from /Users/richard/src/ipfs-webui/app/scripts/views/globe.js, which doesn't seem to have the same convention. Maybe we should make a styleguide? Also, there's a console.warn on the same page... |
|
@RichardLitt yeah that all should be fixed in #155 |
| } | ||
|
|
||
| return result | ||
| } catch (e) { | ||
| console.warn('LocalStorage error: ' + e.message) | ||
| console.warn(e.message) |
There was a problem hiding this comment.
Let's use debug here as well
There was a problem hiding this comment.
But with a warn level: const warn = debug('utils:localStorage:warn') or sth like that
As noted by @diasdavid in ipfs#130 (comment)
RichardLitt
force-pushed
the
feature/add-log
branch
from
177d031
to
d448dd3
Compare
|
LGTM :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted by @diasdavid in #130 (comment)