feat: share countly data with ipfs desktop #1136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
share the same device id and consents between web ui and ipfs desktop License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>
License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>
License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>
License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>
|
Made some changes to track IPFS Desktop Settings toggle through Web UI instead so we could even simplify the code on IPFS Desktop side. We are tracking if they are enabled or disabled or if toggling failed. Also, we now show to the users the tracked actions by IPFS Desktop through a custom selector in IPFS Desktop bundle. We now also track the session time in Web UI as we used to ipfs/ipfs-desktop#1068 (review) |
License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>
License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>
License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>
This was referenced Sep 8, 2019
Closed
Closed
License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>
|
@olizilla I'm merging this, this looks okay and it fixes the issues we talked about (it merges the old user data with the new!). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows Web UI to receive the Countly Key and Device ID from IPFS Desktop itself. With that, the data can be better analysed. Also, this shares the consents we make on Web UI so Desktop knows what to send and what not to.
Please see ipfs/ipfs-desktop#1068
License: MIT
Signed-off-by: Henrique Dias hacdias@gmail.com