-
Notifications
You must be signed in to change notification settings - Fork 865
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ipfs-desktop config can disable autoUpdate #2651
Conversation
see #2613 (comment) for more details fixes #2613
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My only concern with this is fragmentation, more people across more versions. Harder to support!
But if you feel this is good to have, go for it.
I talked to lidel about it. I mean, our first fix suggestion is to upgrade to latest.. So if people do turn off autoUpdate we wont be able to do much. But thats also why I dont want a UI option for it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, but it should be a flag that controls disabling, not enabling – see comment inline
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(that is to say, ok to ship once feedback above addressed)
Co-authored-by: Marcin Rataj <lidel@lidel.org>
Co-authored-by: Marcin Rataj <lidel@lidel.org>
see #2613 (comment) for more details
fixes #2613