Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use CIDv1 by default #2402

Merged
merged 2 commits into from
Feb 21, 2023
Merged

Use CIDv1 by default #2402

merged 2 commits into from
Feb 21, 2023

Conversation

davidd8
Copy link
Contributor

@davidd8 davidd8 commented Feb 3, 2023

IPFS desktop currently defaults to using CIDv0 when importing files and adding them to IPFS. This PR changes the default to use CIDv1.

This should solve #2361 and make sure IPFS Desktop is using the most up-to-date CID standard.

@davidd8 davidd8 requested a review from a team as a code owner February 3, 2023 04:52
@welcome
Copy link

welcome bot commented Feb 3, 2023

Thank you for submitting this PR!
A maintainer will be here shortly to review it.
We are super grateful, but we are also overloaded! Help us by making sure that:

  • The context for this PR is clear, with relevant discussion, decisions
    and stakeholders linked/mentioned.

  • Your contribution itself is clear (code comments, self-review for the
    rest) and in its best form. Follow the code contribution
    guidelines

    if they apply.

Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
Next steps:

  • A maintainer will triage and assign priority to this PR, commenting on
    any missing things and potentially assigning a reviewer for high
    priority items.

  • The PR gets reviews, discussed and approvals as needed.

  • The PR is merged by maintainers when it has been approved and comments addressed.

We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution.
We are very grateful for your contribution!

@SgtPooki
Copy link
Member

SgtPooki commented Feb 7, 2023

Thanks for this @davidd8 ! I just approved the CI tests to run and will review once passing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding a file/folder from disk should use CIDv1 by default.
2 participants