feat: enable pubsub via settings menu

[andrew]

Part of #1647

Adds a menu preference option to enable pubsub which adds a flag to the ipfsd-ctl options for startup.

Question: should this prompt a restart, given that the setting won't take effect until ipfs has been been restarted?

Bug: I'm getting the enabled/disabled message logged twice when clicking on the menu item, not quite sure why :

$ npm start

> ipfs-desktop@0.13.2 start
> cross-env NODE_ENV=development electron .

2021-01-19T16:19:06.988Z info: [meta] logs can be found on /Users/andrewnesbitt/Library/Application Support/IPFS Desktop
2021-01-19T16:19:10.560Z info: [web ui] window ready
2021-01-19T16:19:10.560Z info: [tray] starting
2021-01-19T16:19:10.607Z info: [tray] started
2021-01-19T16:19:10.608Z info: [ipfsd] start daemon STARTED
2021-01-19T16:19:10.937Z info: [daemon] removing api file
2021-01-19T16:19:11.954Z info: [ipfsd] start daemon FINISHED 1.3460042808055879s
2021-01-19T16:19:11.957Z info: [launch on startup] unavailable during development
2021-01-19T16:19:11.972Z info: [pubsub] disabled
2021-01-19T16:19:11.975Z info: [ipfs on path] no action taken
2021-01-19T16:19:17.770Z info: [pubsub] enabled
2021-01-19T16:19:17.791Z info: [pubsub] enabled
2021-01-19T16:22:36.969Z info: [pubsub] disabled
2021-01-19T16:22:37.000Z info: [pubsub] disabled

[jessicaschilling]

@lidel, can you please have a look as you're able?

[lidel]

@andrew looks and works great! ❤️

• Moved PubSub toggle to experiments, because it is marked as one in go-ipfs docs:
  https://github.com/ipfs/go-ipfs/blob/master/docs/experimental-features.md#ipfs-pubsub
• Fixed the duplicated message in 47f83cb
• We have to restart go-ipfs to have the flagg applied, so I've added code that triggers restart via ipcMain.emit('ipfsConfigChanged')
  • While doing that found a bug in logic responsible for restarting the node on config changes. Took me a while to realize where the duplicated process comes from.
  • Ended up bumping ipfsd-ctl, as the bug seems to be fixed in fix: kill disposable nodes on stop and simplify started status js-ipfsd-ctl#554
  • 👉 It works as expected on Linux, mind testing on macOS before I merge this?
    • Toggling Enable PubSub should restart the node now.
    • Standalone Restart action in the main menu should also work

[olizilla]

What if we enabled pubsub by default 🙀 💞

[lidel]

@olizilla if we do it here, we also should enable it in Brave (:lion: → 🙀)
Meanwhile, on the pubsub track there are open issues, would you pull the lever? 🚂 🚋🚋🚋

I'd rather wait for ipfs/kubo#5383 and ipfs/kubo#6621 😅

[andrew]

Wow, thanks for the updates @lidel, I was only expecting some pointers, not just for you to finish the pr!

Tested on macOS, working as expected, restarting correctly and such 🎉

[lidel]

@andrew I would give pointers but then found the unrelated bug, and it escalated 😅
I simplified it a bit (run out of coffee yesterday), mind checking again?
(I want to ship this this or next week because of the bug we've fixed in this PR :))

[andrew]

Retested on macOS, still looking good 👍