Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: go-ipfs v0.7.0 and ipfs-webui v2.11.2 #1638

Merged
merged 16 commits into from
Sep 30, 2020
Merged

feat: go-ipfs v0.7.0 and ipfs-webui v2.11.2 #1638

merged 16 commits into from
Sep 30, 2020

Conversation

rafaelramalho19
Copy link
Contributor

@rafaelramalho19 rafaelramalho19 commented Sep 11, 2020

cc ipfs/kubo#7560

closes #1639 (by upgrading to webui v2.11.1)

@lidel
Copy link
Member

lidel commented Sep 14, 2020

Ugh, I just realized this won't be an easy upgrade:

  • go-ipfs-dep is deprecated and now we use go-ipfs package (both on NPM)
  • ipfsd-ctl used for daemon orchestration is ancient and depends on go-ipfs-dep + uses old JS API

I did ipfsd-ctl update recently so it should be still fresh in my mind – I'll take a stab at updating and comment on this PR later.

This removed  go-ipfs-dep dependency and uses go-ipfs with the latest
http-client and ipfsd-ctl

License: MIT
Signed-off-by: Marcin Rataj <lidel@lidel.org>
License: MIT
Signed-off-by: Marcin Rataj <lidel@lidel.org>
@lidel

This comment has been minimized.

rafaelramalho19 and others added 8 commits September 14, 2020 22:09
This removed  go-ipfs-dep dependency and uses go-ipfs with the latest
http-client and ipfsd-ctl

License: MIT
Signed-off-by: Marcin Rataj <lidel@lidel.org>
License: MIT
Signed-off-by: Marcin Rataj <lidel@lidel.org>
This is CID of webui from ipfs/ipfs-webui#1628
will be switched to release after patch one is tagged upstream

License: MIT
Signed-off-by: Marcin Rataj <lidel@lidel.org>
License: MIT
Signed-off-by: Marcin Rataj <lidel@lidel.org>
Do not build feature branch with open Pull Requests,
should remove redundant appveyor job on PRs.

License: MIT
Signed-off-by: Marcin Rataj <lidel@lidel.org>
Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is ready, thank you @rafaelramalho19 – we just wait for official 0.7.0 now.

(if you plan to do more dev in ipfs-desktop, it's ok to merge this as-is and then bump to non-RC version before release, if not, ok to park this until final release)

Switching to release version

License: MIT
Signed-off-by: Marcin Rataj <lidel@lidel.org>
@lidel lidel changed the title chore: bump go-ipfs version to 0.7.0-rc2 feat: go-ipfs v0.7.0 and ipfs-webui v2.11.1 Sep 23, 2020
@lidel
Copy link
Member

lidel commented Sep 23, 2020

@rafaelramalho19 I've bumped this PR to the release version of go-ipfs 0.7.0 and looks good on Linux.

Mind building on mac and windows and confirming there are no surprises?
The usual smoke-test is to start Desktop app and them upload a directory with cat pictures via embedded WebUI.

@crcastle
Copy link

crcastle commented Sep 27, 2020

@lidel I was wanting to use go-ipfs 0.7.0 with the desktop app on Mac, so I figured I'd do a Mac smoke test for you. Looks good!

npm ci on this branch followed by npm start and uploading a folder of (Creative Commons licensed) cats works as expected: https://ipfs.io/ipfs/QmRCjyh61g4P31wjTDtdRk9B75CRkiLWPAPPQtQcXHmCs9

Tested with Node 12.16.3 and 14.12.0.

Running npm ci with node 14.12.0 produced a bunch of warnings but didn't affect the smoke test steps.

`npm ci` warnings with node 14.12.0:

<snip>

(node:12955) Warning: Accessing non-existent property 'cat' of module exports inside circular dependency
(Use `node --trace-warnings ...` to show where the warning was created)
(node:12955) Warning: Accessing non-existent property 'cd' of module exports inside circular dependency
(node:12955) Warning: Accessing non-existent property 'chmod' of module exports inside circular dependency
(node:12955) Warning: Accessing non-existent property 'cp' of module exports inside circular dependency
(node:12955) Warning: Accessing non-existent property 'dirs' of module exports inside circular dependency
(node:12955) Warning: Accessing non-existent property 'pushd' of module exports inside circular dependency
(node:12955) Warning: Accessing non-existent property 'popd' of module exports inside circular dependency
(node:12955) Warning: Accessing non-existent property 'echo' of module exports inside circular dependency
(node:12955) Warning: Accessing non-existent property 'tempdir' of module exports inside circular dependency
(node:12955) Warning: Accessing non-existent property 'pwd' of module exports inside circular dependency
(node:12955) Warning: Accessing non-existent property 'exec' of module exports inside circular dependency
(node:12955) Warning: Accessing non-existent property 'ls' of module exports inside circular dependency
(node:12955) Warning: Accessing non-existent property 'find' of module exports inside circular dependency
(node:12955) Warning: Accessing non-existent property 'grep' of module exports inside circular dependency
(node:12955) Warning: Accessing non-existent property 'head' of module exports inside circular dependency
(node:12955) Warning: Accessing non-existent property 'ln' of module exports inside circular dependency
(node:12955) Warning: Accessing non-existent property 'mkdir' of module exports inside circular dependency
(node:12955) Warning: Accessing non-existent property 'rm' of module exports inside circular dependency
(node:12955) Warning: Accessing non-existent property 'mv' of module exports inside circular dependency
(node:12955) Warning: Accessing non-existent property 'sed' of module exports inside circular dependency
(node:12955) Warning: Accessing non-existent property 'set' of module exports inside circular dependency
(node:12955) Warning: Accessing non-existent property 'sort' of module exports inside circular dependency
(node:12955) Warning: Accessing non-existent property 'tail' of module exports inside circular dependency
(node:12955) Warning: Accessing non-existent property 'test' of module exports inside circular dependency
(node:12955) Warning: Accessing non-existent property 'to' of module exports inside circular dependency
(node:12955) Warning: Accessing non-existent property 'toEnd' of module exports inside circular dependency
(node:12955) Warning: Accessing non-existent property 'touch' of module exports inside circular dependency
(node:12955) Warning: Accessing non-existent property 'uniq' of module exports inside circular dependency
(node:12955) Warning: Accessing non-existent property 'which' of module exports inside circular dependency
(node:12957) Warning: Accessing non-existent property 'cat' of module exports inside circular dependency
(Use `node --trace-warnings ...` to show where the warning was created)
(node:12957) Warning: Accessing non-existent property 'cd' of module exports inside circular dependency
(node:12957) Warning: Accessing non-existent property 'chmod' of module exports inside circular dependency
(node:12957) Warning: Accessing non-existent property 'cp' of module exports inside circular dependency
(node:12957) Warning: Accessing non-existent property 'dirs' of module exports inside circular dependency
(node:12957) Warning: Accessing non-existent property 'pushd' of module exports inside circular dependency
(node:12957) Warning: Accessing non-existent property 'popd' of module exports inside circular dependency
(node:12957) Warning: Accessing non-existent property 'echo' of module exports inside circular dependency
(node:12957) Warning: Accessing non-existent property 'tempdir' of module exports inside circular dependency
(node:12957) Warning: Accessing non-existent property 'pwd' of module exports inside circular dependency
(node:12957) Warning: Accessing non-existent property 'exec' of module exports inside circular dependency
(node:12957) Warning: Accessing non-existent property 'ls' of module exports inside circular dependency
(node:12957) Warning: Accessing non-existent property 'find' of module exports inside circular dependency
(node:12957) Warning: Accessing non-existent property 'grep' of module exports inside circular dependency
(node:12957) Warning: Accessing non-existent property 'head' of module exports inside circular dependency
(node:12957) Warning: Accessing non-existent property 'ln' of module exports inside circular dependency
(node:12957) Warning: Accessing non-existent property 'mkdir' of module exports inside circular dependency
(node:12957) Warning: Accessing non-existent property 'rm' of module exports inside circular dependency
(node:12957) Warning: Accessing non-existent property 'mv' of module exports inside circular dependency
(node:12957) Warning: Accessing non-existent property 'sed' of module exports inside circular dependency
(node:12957) Warning: Accessing non-existent property 'set' of module exports inside circular dependency
(node:12957) Warning: Accessing non-existent property 'sort' of module exports inside circular dependency
(node:12957) Warning: Accessing non-existent property 'tail' of module exports inside circular dependency
(node:12957) Warning: Accessing non-existent property 'test' of module exports inside circular dependency
(node:12957) Warning: Accessing non-existent property 'to' of module exports inside circular dependency
(node:12957) Warning: Accessing non-existent property 'toEnd' of module exports inside circular dependency
(node:12957) Warning: Accessing non-existent property 'touch' of module exports inside circular dependency
(node:12957) Warning: Accessing non-existent property 'uniq' of module exports inside circular dependency
(node:12957) Warning: Accessing non-existent property 'which' of module exports inside circular dependency
added 1207 packages in 37.726s

@rafaelramalho19 rafaelramalho19 changed the title feat: go-ipfs v0.7.0 and ipfs-webui v2.11.1 feat: go-ipfs v0.7.0 and ipfs-webui v2.11.2 Sep 28, 2020
@rafaelramalho19
Copy link
Contributor Author

@lidel v.2.11.2 is now on this PR 👌

Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but CI on macOS fails due to Apple notarization:

1 package(s) were not uploaded because they had problems:

	/var/folders/17/5mc7816d3mndxjqgplq6057w0000gn/T/FCE68004-143C-41A9-8B85-08020C829FF0/io.ipfs.desktop.itmsp - Error Messages:

		You must first sign the relevant contracts online. (1048)

2020-09-28 15:43:08.319 altool[4208:12324] *** Error: You must first sign the relevant contracts online. (1048)

Before this is merged we need to fix notarization so the CI is green.

@rafaelramalho19
Copy link
Contributor Author

@lidel all ready for final reviews 🎉

Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet! Let's merge, do final eyeballing and if master looks good, start release dance for v0.13

@lidel lidel merged commit bc5db45 into master Sep 30, 2020
@lidel lidel deleted the chore/bump-go-ipfs branch September 30, 2020 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Downloading a file results in a corrupted archive
3 participants