fix: windows auto-update feature when selecting install for all users

[rafaelramalho19]

Fixes #1514

[lidel]

don't we also need to add code that sets _installOnQuit ? (set it to true in update-downloaded etc)?

[rafaelramalho19]

don't we also need to add code that sets _installOnQuit ? (set it to true in update-downloaded etc)?

Yes! Sorry about that, was juggling between my macbook & desktop and ended up screwing the one I wanted to push 😅

[lidel]

LGTM, should be safe to merge (assuming we don't hit any other upstream bugs 🤞 😬)

TL;DR on why disabling autoInstallOnAppQuit is "safe"

autoUpdater.quitAndInstall() docs state that:

Note: It is not strictly necessary to call this function to apply an update, as a successfully downloaded update will always be applied the next time the application starts.

In other words, according to Electron docs, autoUpdater.autoInstallOnAppQuit = false does not disable installation of updates, only postpones it until the next time app starts – so pretty safe from the auto-update standpoint.