fix: ignore net:: errors #1270
Merged
fix: ignore net:: errors #1270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>
lidel
reviewed
Dec 1, 2019
| if (err.stack.includes('net::')) { | ||
| return | ||
| } | ||
|
|
||
| logger.error(err) |
There was a problem hiding this comment.
could we move this logger before the if, so its always logged?
Or are we ignoring this on purpose, due to noise?
There was a problem hiding this comment.
I was just thinking about ignoring the noise caused by Internet issues...
There was a problem hiding this comment.
Just to be sure I got this right, this is when ipfs-desktop tries to access API that is offline, or are there other uses of this code path?
There was a problem hiding this comment.
AFAIK, it's when we try to access the API and it is offline. However, it shouldn't happen many times.
On previous occasions, this would happen with Auto Updater, when we didn't catch the errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This aims to fix #1267. I don't know how to reproduce the error so I'm not sure if this is going to fix it. Those errors never have stack trace so it's hard to understand them. However, I believe this might fix it because it just ignores errors with
net::on it generated by unhandled rejections and exceptions.License: MIT
Signed-off-by: Henrique Dias hacdias@gmail.com