fix: redirect to native URI in Brave #960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a cosmetic fix that ensures IPFS resources are redirected to ipfs:// or ipns:// URI and that URI is displayed in the browser UI in the address bar. Due to the way Brave implemented URI cloak for local HTTP-based gateway provided by go-ipfs managed by the browser itself the regular redirect done via webRequest API did not produce native URI in address bar. However, tabs.update does the trick, so we use that for root requests.
|
I'm fast-tracking this to Beta channel, so we can ship it together with #959 before BRave 1.19 hits Stable this week 💨
|
autonome
approved these changes
Jan 18, 2021
| if (!contentPath) return null | ||
| return contentPath.replace(/^\/(ip[f|n]s)\//, '$1://') | ||
| } | ||
| exports.ipfsUri = ipfsUri |
There was a problem hiding this comment.
can you verbify the function name in a way that makes what it does more explicit?
| it('should return null if there is no valid path for input path', function () { | ||
| const path = '/invalid/QmbWqxBEKC3P8tqsKc98xmWNzrzDtRLMiMPL8wBuTGsMnR' | ||
| expect(ipfsUri(path)).to.equal(null) | ||
| }) |
There was a problem hiding this comment.
lots of positive tests, should add negative tests too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a cosmetic fix that ensures IPFS resources are redirected to
ipfs://oripns://URI and that URI is displayed in the browser UIin the address bar.
Due to the way Brave implemented URI cloak for local HTTP-based gateway
provided by go-ipfs managed by the browser itself the regular redirect
done via webRequest API did not produce native URI in address bar.
However,
tabs.updatedoes the trick, so we use that for root requests.We can remove this in the future, if webRequest behavior is fixed.
cc @autonome (mitigates issue we both discovered independently)