Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change DNS resolution endpoint to allow ipns recursive resolution #959

Merged
merged 2 commits into from
Jan 17, 2021
Merged

Change DNS resolution endpoint to allow ipns recursive resolution #959

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dea7dad
Change DNS resolution endpoint to allow ipns recursive resolution
Ktl-XV Jan 15, 2021
15a6de8
fix: make DNSLink check non-recursive
lidel Jan 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion add-on/src/lib/dnslink.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ module.exports = function createDnslinkResolver (getState) {
// js-ipfs-api does not provide method for fetching this
// TODO: revisit after https://github.com/ipfs/js-ipfs-api/issues/501 is addressed
// TODO: consider worst-case-scenario fallback to https://developers.google.com/speed/public-dns/docs/dns-over-https
const apiCall = `${apiProvider}api/v0/dns/${fqdn}?r=true`
const apiCall = `${apiProvider}api/v0/name/resolve/${fqdn}`
const xhr = new XMLHttpRequest() // older XHR API us used because window.fetch appends Origin which causes error 403 in go-ipfs
// synchronous mode with small timeout
// (it is okay, because we do it only once, then it is cached and read via readAndCacheDnslink)
Expand Down