fix: restore ESR compatibility #812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
Motivation
This makes Companion once again compatible with Firefox ESR and Fennec-based Firefox for Android.
How to test 🎶
A way to test this is to open Firefox 68 (ESR) and go to https://audius.co using Firefox ESR and start listening to music. XHR requests sent to public gateways should get cancelled before receiving first byte of payload, and a late redirect to local gateway replaces them. (Firefox >69 redirects immediately, without the need to cancel original requet mid-flight)
Closes #784
Closes #779
CC #436