-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Per-site Redirect Opt-out #687
Commits on Feb 20, 2019
-
feat: per-site redirect opt-out
Changes: - moved global redirect toggle from Browser Action menu to the utility icon row, under "redirect" icon - added animation to utility icons - global redirect icon will enable integrations if clicked when in suspended state - menu items specific to the Active Tab are marked with additional border (just a prototype, needs refinement) - Redirect opt-out per site - new menu item in Active Tab section - when clicked on regular site toggles redirect for current FQDN and all its subdomains - when clicked on /ipns/<fqdn>/ (DNSLink) website, toggles redirect for <fqdn> - after redirect preference changes for current website, the tab is reloaded - DNSLink websites are reloaded to with URL change between IPNS path and original URL - redirect preference applies not only to requests to URLs with with FQDN of the active tab, but also to all subresource requests that have it in `originUrl` (Firefox) or `Referer` header (Chrome)
Configuration menu - View commit details
-
Copy full SHA for eb8723a - Browse repository at this point
Copy the full SHA eb8723aView commit details
Commits on Feb 23, 2019
-
style: change labels on global toggles
Following suggestion from #687 (comment)
Configuration menu - View commit details
-
Copy full SHA for ba20aa7 - Browse repository at this point
Copy the full SHA ba20aa7View commit details -
refactor: switch dnslink tests to subrequests
The request for main page (request.type=main_request) is often optimized early by preloading DNSLink etc. We switch tests to one of subrequest types to ensure the test is not impacted by main_test logic.
Configuration menu - View commit details
-
Copy full SHA for 8d1f3b3 - Browse repository at this point
Copy the full SHA 8d1f3b3View commit details -
style(browserAction): tweak style of active tab items
This removes dotted border and introduces familiar grandient as sugegsted in #687 (comment)
Configuration menu - View commit details
-
Copy full SHA for 1f939d6 - Browse repository at this point
Copy the full SHA 1f939d6View commit details
Commits on Feb 24, 2019
-
feat(options): UI for editing redirect opt-outs
This adds a textarea for editing per-site opt-outs. Array is converted into multi-line text. Entries that are not valid FQDNs are dropped. The list is sorted lexicographically.
Configuration menu - View commit details
-
Copy full SHA for 86f5fcf - Browse repository at this point
Copy the full SHA 86f5fcfView commit details
Commits on Feb 25, 2019
-
refactor: code cleanup and SVG optimization
- removed unused paths from redirect-icon SVG - small code cleanup
Configuration menu - View commit details
-
Copy full SHA for ada2ddb - Browse repository at this point
Copy the full SHA ada2ddbView commit details
Commits on Feb 26, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 2394847 - Browse repository at this point
Copy the full SHA 2394847View commit details -
refactor: isRedirectPageActionsContext
Added ipfsPathValidator.isRedirectPageActionsContext with tests: Per-site toggle won't be shown on internal pages and non-IPNS urls loaded from local gateway (confusing to users) Removed redundant variables in Browser Action context and made UI less jittery.
Configuration menu - View commit details
-
Copy full SHA for 82cae05 - Browse repository at this point
Copy the full SHA 82cae05View commit details
Commits on Mar 4, 2019
-
style(ux): redirect toggles with @material/switch
It was raised during the review that labels should not change. This changes the UI of redirect toggles from dynamic label to static label + @material/switch
Configuration menu - View commit details
-
Copy full SHA for dfe5040 - Browse repository at this point
Copy the full SHA dfe5040View commit details -
style(ux): remove redirect toggle icon
We already have it as regular menu item, and the switch glyph seems to confuse people about its purpose, so let's remove UI cruft and hide the icon toggle for now. Another small tweak is to fade out global toggle instead of hiding it in offline mode, which removes unnecessary jitter from UI.
Configuration menu - View commit details
-
Copy full SHA for 4215c4c - Browse repository at this point
Copy the full SHA 4215c4cView commit details -
style(browserAction): move Active Tab section to the top
+ unify labels related to redirects
Configuration menu - View commit details
-
Copy full SHA for f17ae7c - Browse repository at this point
Copy the full SHA f17ae7cView commit details