Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Per-site Redirect Opt-out #687

Merged
merged 11 commits into from
Mar 5, 2019
Merged

Per-site Redirect Opt-out #687

merged 11 commits into from
Mar 5, 2019

Commits on Feb 20, 2019

  1. feat: per-site redirect opt-out

    Changes:
    
    - moved global redirect toggle from Browser Action menu to the utility
      icon row, under "redirect" icon
    - added animation to utility icons
    - global redirect icon will enable integrations if clicked when in
      suspended state
    - menu items specific to the Active Tab are marked with additional
      border (just a prototype, needs refinement)
    - Redirect opt-out per site
      - new menu item in Active Tab section
      - when clicked on regular site toggles redirect for current FQDN and
        all its subdomains
      - when clicked on /ipns/<fqdn>/ (DNSLink) website, toggles redirect for <fqdn>
      - after redirect preference changes for current website, the tab is
        reloaded
      - DNSLink websites are reloaded to with URL change between IPNS path
        and original URL
      - redirect preference applies not only to requests to URLs with with FQDN
        of the active tab, but also to all subresource requests that have it
        in `originUrl` (Firefox) or `Referer` header (Chrome)
    lidel committed Feb 20, 2019
    Configuration menu
    Copy the full SHA
    eb8723a View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2019

  1. style: change labels on global toggles

    Following suggestion from
    #687 (comment)
    lidel committed Feb 23, 2019
    Configuration menu
    Copy the full SHA
    ba20aa7 View commit details
    Browse the repository at this point in the history
  2. refactor: switch dnslink tests to subrequests

    The request for main page (request.type=main_request) is often optimized
    early by preloading DNSLink etc.
    
    We switch tests to one of subrequest types to ensure the test is not
    impacted by main_test logic.
    lidel committed Feb 23, 2019
    Configuration menu
    Copy the full SHA
    8d1f3b3 View commit details
    Browse the repository at this point in the history
  3. style(browserAction): tweak style of active tab items

    This removes dotted border and introduces familiar grandient
    as sugegsted in
    #687 (comment)
    lidel committed Feb 23, 2019
    Configuration menu
    Copy the full SHA
    1f939d6 View commit details
    Browse the repository at this point in the history

Commits on Feb 24, 2019

  1. feat(options): UI for editing redirect opt-outs

    This adds a textarea for editing per-site opt-outs.
    Array is converted into multi-line text.
    Entries that are not valid FQDNs are dropped.
    The list is sorted lexicographically.
    lidel committed Feb 24, 2019
    Configuration menu
    Copy the full SHA
    86f5fcf View commit details
    Browse the repository at this point in the history

Commits on Feb 25, 2019

  1. refactor: code cleanup and SVG optimization

    - removed unused paths from redirect-icon SVG
    - small code cleanup
    lidel committed Feb 25, 2019
    Configuration menu
    Copy the full SHA
    ada2ddb View commit details
    Browse the repository at this point in the history

Commits on Feb 26, 2019

  1. Configuration menu
    Copy the full SHA
    2394847 View commit details
    Browse the repository at this point in the history
  2. refactor: isRedirectPageActionsContext

    Added ipfsPathValidator.isRedirectPageActionsContext with tests:
    Per-site toggle won't be shown on internal pages and non-IPNS urls
    loaded from local gateway (confusing to users)
    
    Removed redundant variables in Browser Action context and made UI less
    jittery.
    lidel committed Feb 26, 2019
    Configuration menu
    Copy the full SHA
    82cae05 View commit details
    Browse the repository at this point in the history

Commits on Mar 4, 2019

  1. style(ux): redirect toggles with @material/switch

    It was raised during the review that labels should not change.
    
    This changes the UI of redirect toggles from dynamic label
    to static label + @material/switch
    lidel committed Mar 4, 2019
    Configuration menu
    Copy the full SHA
    dfe5040 View commit details
    Browse the repository at this point in the history
  2. style(ux): remove redirect toggle icon

    We already have it as regular menu item, and the switch glyph seems to
    confuse people about its purpose, so let's remove UI cruft and hide the
    icon toggle for now.
    
    Another small tweak is to fade out global toggle instead of hiding it
    in offline mode, which removes unnecessary jitter from UI.
    lidel committed Mar 4, 2019
    Configuration menu
    Copy the full SHA
    4215c4c View commit details
    Browse the repository at this point in the history
  3. style(browserAction): move Active Tab section to the top

    + unify labels related to redirects
    lidel committed Mar 4, 2019
    Configuration menu
    Copy the full SHA
    f17ae7c View commit details
    Browse the repository at this point in the history