Opening .eth creates 2 tabs

[abueide]

Describe the bug
A clear and concise description of what the bug is.

when I click on this link: http://ipfs.eth I end up with two tabs: www.ipfs.eth (doesn't load, says it could not connect), and another new tab gets opened to ipfs.eth.link which loads properly. Why is it loading in a new tab instead of redirecting in the old tab? I don't want two tabs every time I click/type in a .eth link. It happens on http://almonit.eth too. Happens in firefox/chrome.

To Reproduce
Steps to reproduce the behavior:
Click on this link with ipfs companion installed in firefox: http://ipfs.eth

Expected behavior
A single tab redirecting to ipfs.eth.link, or at least an option to disable ens name resolution.

Screenshots
If applicable, add screenshots to help explain your problem.

[lidel]

Original tab fails because browser is unable to connect to the server (.eth is not a real TLD).

By default IPFS Companion tries to recover from various HTTP failures by checking for DNSLink record and recovering in a new tab, and that is what you observe here.

That being said, I agree .eth is a special case and instead of opening a new tab, we could improve UX by updating URL of original one.

I suspect the fix is to change this line:

      // Check if error can be recovered via EthDNS
      if (isRecoverableViaEthDNS(request, state)) {
        const url = new URL(request.url)
        url.hostname = `${url.hostname}.link`
        const redirectUrl = url.toString()
        log(`onErrorOccurred: attempting to recover from DNS error (${request.error}) using EthDNS for ${request.url} → ${redirectUrl}`, request)
-        // TODO: update existing tab
-        return createTabWithURL(request, redirectUrl, browser, recoveredTabs)
+        browser.tabs.update({ url: fixedUrl })
+        return
      }

@abueide is this something you would be interested in submitting PR for?

[abueide]

@lidel sure, I tested it and its working now. Should I replace the ones in the isRecoverable and isRecoverableViaDNSLink functions for the PR as well?

[lidel]

@abueide yes, I believe it will be less confusing than having two tabs for now.

Instead of changing this everywhere please:

1. rename createTabWithURL to updateTabWithURL and switch its internals to browser.tabs.update
2. recoveredTabs cache can be removed - afaik no longer needed (we used it to fix some Chromium quirks)

Thanks!