Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't connect to API over HTTPS after upgrading to 2.8.0 #706

Closed
xuhcc opened this issue Apr 7, 2019 · 3 comments · Fixed by #707
Closed

Can't connect to API over HTTPS after upgrading to 2.8.0 #706

xuhcc opened this issue Apr 7, 2019 · 3 comments · Fixed by #707
Assignees
@lidel
Labels
kind/bug A bug in existing code (including security flaws) P1 High: Likely tackled by core team if no one steps up

Comments

@xuhcc
Copy link

xuhcc commented Apr 7, 2019

OS: ArchLinux
Browser: Firefox 66.0.2

I'm using a custom IPFS gateway (API URL https://***:5002). The "Redirect to gateway" switch in popup UI immediately returns back to "off" position. Browser console contains the following messages:

Error while ipfs.swarm.peers: ReferenceError: https is not defined backgroundPage.bundle.js:85:316595
[ipfs-companion] IPFS API is Offline: Automatic Mode: Public Gateway will be used as a fallback backgroundPage.bundle.js:181:107019
@lidel lidel self-assigned this Apr 8, 2019
@lidel lidel added kind/bug A bug in existing code (including security flaws) P1 High: Likely tackled by core team if no one steps up labels Apr 8, 2019
@lidel
Copy link
Member

lidel commented Apr 8, 2019

Thank you for reporting this. It seems to be a bug from ipfs-inactive/js-ipfs-http-client#959
I will prepare bugfix release shortly.

@lidel lidel changed the title Can't connect to custom gateway after upgrading to 2.8.0 Can't connect to API over HTTPS after upgrading to 2.8.0 Apr 8, 2019
lidel added a commit that referenced this issue Apr 8, 2019
@lidel
fix: support HTTPS API endpoint
98c8263 
This fixes regresssion of #654 introduced by js-ipfs-http-client
ipfs-inactive/js-ipfs-http-client#959

Closes #706
@lidel lidel mentioned this issue Apr 8, 2019
Merged
@ghost ghost added the status/in-progress In progress label Apr 8, 2019
@lidel lidel closed this as completed in #707 Apr 8, 2019
lidel added a commit that referenced this issue Apr 8, 2019
@lidel
fix: support HTTPS API endpoint (#707)
fde1deb 
This fixes regresssion of #654 introduced by js-ipfs-http-client
ipfs-inactive/js-ipfs-http-client#959

Closes #706
@ghost ghost removed the status/in-progress In progress label Apr 8, 2019
@xuhcc
Copy link
Author

xuhcc commented Apr 8, 2019

@lidel Thank you! I just tested v2.8.0.770 and the problem is gone.

However, there is another issue that could be somehow related to this one. When I open Web UI using the "Open Web UI" menu item, page loads with error "Failed to connect to the API." It started to happen before 2.8.0, nearly a month ago (reported here ipfs/ipfs-webui#989).

@lidel
Copy link
Member

lidel commented Apr 8, 2019

@xuhcc Cool! I'll ship the fix to Stable Channel as 2.8.1

The bug with Web UI needs to be solved upstream, lets continue in ipfs/ipfs-webui#989

@github-actions github-actions bot mentioned this issue Feb 16, 2023
Closed
@github-actions github-actions bot mentioned this issue Sep 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lidel lidel

Labels
kind/bug A bug in existing code (including security flaws) P1 High: Likely tackled by core team if no one steps up
Projects
None yet
Milestone
No milestone
2 participants
@lidel @xuhcc