Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: filter bitswap providers in ipni client #72

Merged
merged 6 commits into from
Oct 7, 2024
Merged

feat: filter bitswap providers in ipni client #72

merged 6 commits into from
Oct 7, 2024

Conversation

2color
Copy link
Member

@2color 2color commented Oct 1, 2024 •
edited by lidel
Loading

Fixes #70 by configuring filtering in the delegated routing client instance used to query the IPNI

TODO before merging

Tasks
Beta Give feedback

@lidel lidel mentioned this pull request Oct 1, 2024
Closed
lidel
lidel reviewed Oct 1, 2024
View reviewed changes
daemon.go Show resolved Hide resolved
lidel
lidel approved these changes Oct 4, 2024
View reviewed changes
Copy link
Member

@lidel lidel left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm (updated to release boxo and go-libp2p) – @2color feel free to merge and deploy when you have time next week

@2color 2color merged commit 46493fe into main Oct 7, 2024
11 checks passed
@2color 2color deleted the filter-unactionable branch October 7, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lidel lidel lidel approved these changes

@aschmahmann aschmahmann Awaiting requested review from aschmahmann

@gammazero gammazero Awaiting requested review from gammazero

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Skip unactionable providers in check
2 participants
@2color @lidel