This repository has been archived by the owner on Aug 1, 2023. It is now read-only.
test: improve exchange files #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
1 task
jacobheun
force-pushed
the
test/libp2p-next
branch
from
8508b5c
to
dc7c572
Compare
alanshaw
approved these changes
Apr 11, 2019
|
LGTM and tests passing locally |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue with relay configuration for the upcoming js-ipfs release.
Also:
Exchange files
I refactored the exchange files tests to make them less prone to accidentally communicating with each other. While this is valuable scenario testing, it detracts from the goal of exchange files. I think there is value in having tests that exercise large data transfers with several nodes connected, but those should be separate tests. This will help prevent things like the dht from communicating with other nodes in the test suite without needing to disable them.
This does have a slight impact on startup times for the tests as the nodes are started and shutdown for each exchange files iteration, but overall it should help reduce time by avoiding unwanted network traffic.