-
Notifications
You must be signed in to change notification settings - Fork 15
Conversation
@@ -61,7 +61,7 @@ const dirs = [ | |||
|
|||
const timeout = 240 * 1000 | |||
|
|||
describe.skip('exchange files', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why were these disabled????! 👀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
check this PR interop#42
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to assign P0 to things like these. Two big releases for go-ipfs and js-ipfs were made without testing these at all.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree! Created an issue for tracking it ipfs/interop#45.
56d649c
to
4bc1a8f
Compare
// GB, | ||
// 10 * GB, | ||
// 100 * GB, | ||
// 1000 * GB | ||
] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hugomrdias you have here some pretty solids tests for KR
I've added a go -> go test so that we can compare both implementations. Rest of the results:
I've also made the Directory tests more interesting (with more depth)
|
test/exchange-files.js
Outdated
// TODO these tests are not fetching the full dir?? | ||
describe('get directory', () => dirs.forEach((num) => { | ||
it(`go -> js: depth: 5, num: ${num}`, function () { | ||
// TODO Why aren't these tests fetching the full directory and comparing it?? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whyyyyy??!?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
solved
Seems that Jenkins is completely dead. I can't even enter https://ci.ipfs.team/blue/organizations/jenkins/IPFS%2Finterop/activity @ipfs/infrastructure do you know what's up? |
58abe9f
to
dd02e38
Compare
dd02e38
to
a68f611
Compare
No description provided.