This repository has been archived by the owner on Jun 19, 2023. It is now read-only.
test: fix put with hash test #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We just changed ID/"id" to IDENTITY/"identity" to match the multicodec table and avoid confusion with peer IDs, CIDs, etc. Unfortunately, this breaks the `--hash=id` flag. Luckily, I'm pretty sure nobody's actually using this. As putting a block with an identity hash is useless. If they are users, we can go about adding in backwards compatibility hacks later.
guseggert
pushed a commit
to ipfs/boxo
that referenced
this pull request
Dec 6, 2022
…ing-id-hash-name test: fix put with hash test This commit was moved from ipfs/interface-go-ipfs-core@114c623
guseggert
pushed a commit
to ipfs/boxo
that referenced
this pull request
Mar 15, 2023
…ing-id-hash-name test: fix put with hash test This commit was moved from ipfs/interface-go-ipfs-core@114c623
Jorropo
pushed a commit
to ipfs/go-libipfs-rapide
that referenced
this pull request
Mar 23, 2023
…ing-id-hash-name test: fix put with hash test This commit was moved from ipfs/interface-go-ipfs-core@114c623
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We just changed ID/"id" to IDENTITY/"identity" to match the multicodec table and
avoid confusion with peer IDs, CIDs, etc.
Unfortunately, this breaks the
--hash=idflag. Luckily, I'm pretty surenobody's actually using this. As putting a block with an identity hash is
useless. If they are users, we can go about adding in backwards compatibility
hacks later.