This repository has been archived by the owner on Jun 19, 2023. It is now read-only.
path: drop error from ParsePath #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magik6k
force-pushed
the
feat/drop-path-err
branch
from
8617ca0
to
9a0d495
Compare
magik6k
force-pushed
the
feat/drop-path-err
branch
from
9a0d495
to
f0d8f17
Compare
|
If ParsePath doesn't error it can't really do much parsing, then I would say function name is inaccurate. |
|
That's why I changed it's name to |
magik6k
force-pushed
the
feat/drop-path-err
branch
from
f0d8f17
to
21a7239
Compare
|
(This is ready for a review (modulo some import ordering fixes)) |
Stebalien
approved these changes
Apr 9, 2019
guseggert
pushed a commit
to ipfs/boxo
that referenced
this pull request
Dec 6, 2022
…-path-err path: drop error from ParsePath This commit was moved from ipfs/interface-go-ipfs-core@7786158
guseggert
pushed a commit
to ipfs/boxo
that referenced
this pull request
Mar 15, 2023
…-path-err path: drop error from ParsePath This commit was moved from ipfs/interface-go-ipfs-core@7786158
Jorropo
pushed a commit
to ipfs/go-libipfs-rapide
that referenced
this pull request
Mar 23, 2023
…-path-err path: drop error from ParsePath This commit was moved from ipfs/interface-go-ipfs-core@7786158
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20
TODO extract path related stuff to subpackage