This repository has been archived by the owner on Jun 19, 2023. It is now read-only.
tweak the Ls interface #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thoughts @magik6k? |
1. Avoid `ipld.Link`. This is a protodag specific thing that will go away in future IPLD versions. 2. Avoid exposing the underlying file types. The user shouldn't care if they're dealing with a hamt, etc. 3. Add a field for a symlink's target. 4. Rename LsLink to DirEntry to better this type's role.
Stebalien
added a commit
to ipfs/kubo
that referenced
this pull request
Mar 5, 2019
See: ipfs/interface-go-ipfs-core#14 License: MIT Signed-off-by: Steven Allen <steven@stebalien.com>
magik6k
reviewed
Mar 5, 2019
unixfs.go
Outdated
| // Only filled when asked to resolve the directory entry. | ||
| Size uint64 // The size of the file in bytes (or the size of the symlink). | ||
| Type FileType // The type of the file. | ||
| Target Path // The symlink target (if a symlink). |
There was a problem hiding this comment.
Needs a test (and we should probably expose it via ipfs ls as otherwise it will need to call multiple endpoints to implement fully in http-client)
There was a problem hiding this comment.
SGTM. I've added tests.
(also, fix some error versus fatal nits)
Stebalien
force-pushed
the
feat/nicer-ls
branch
2 times, most recently
from
0124bd8
to
8c2328a
Compare
Stebalien
added a commit
to ipfs/kubo
that referenced
this pull request
Mar 5, 2019
See: ipfs/interface-go-ipfs-core#14 License: MIT Signed-off-by: Steven Allen <steven@stebalien.com>
(path can't represent relative paths)
Stebalien
added a commit
to ipfs/kubo
that referenced
this pull request
Mar 5, 2019
See: ipfs/interface-go-ipfs-core#14 License: MIT Signed-off-by: Steven Allen <steven@stebalien.com>
|
I've also:
|
Stebalien
added a commit
to ipfs/kubo
that referenced
this pull request
Mar 5, 2019
See: ipfs/interface-go-ipfs-core#14 License: MIT Signed-off-by: Steven Allen <steven@stebalien.com>
Stebalien
added a commit
to ipfs/kubo
that referenced
this pull request
Mar 7, 2019
See: ipfs/interface-go-ipfs-core#14 License: MIT Signed-off-by: Steven Allen <steven@stebalien.com>
It's complicated. We need to carefully think through how sizes work.
Stebalien
added a commit
to ipfs/kubo
that referenced
this pull request
Mar 7, 2019
See: ipfs/interface-go-ipfs-core#14 License: MIT Signed-off-by: Steven Allen <steven@stebalien.com>
|
@magik6k I've had to make some changes. Can you take another look? |
magik6k
approved these changes
Mar 7, 2019
Stebalien
added a commit
to ipfs/kubo
that referenced
this pull request
Mar 7, 2019
See: ipfs/interface-go-ipfs-core#14 License: MIT Signed-off-by: Steven Allen <steven@stebalien.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ipld.Link. This is a protodag specific thing that will go away in future IPLD versions.