Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: simplified DNSLink handling on subdomain gws #178

Merged
merged 5 commits into from
Feb 4, 2021

Conversation

lidel
Copy link
Member

@lidel lidel commented Feb 3, 2021

This PR updates Addressing memo to simplify DNSLink handling.

Reason: ipfs/kubo#7847 will ship with go-ipfs 0.8.0 and is already supported at dweb.link

cc @autonome

Simplify DNSLink handling:
ipfs/kubo#7847 will ship with go-ipfs 0.8.0
and is already supported at dweb.link
@lidel lidel requested a review from autonome February 3, 2021 12:20
Copy link

@autonome autonome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! a few optional suggestions for now or future edits

ADDRESSING.md Show resolved Hide resolved
ADDRESSING.md Outdated Show resolved Hide resolved
ADDRESSING.md Outdated Show resolved Hide resolved
@lidel lidel requested a review from autonome February 3, 2021 19:58
@lidel
Copy link
Member Author

lidel commented Feb 3, 2021

@autonome mind taking another look?

Applied your suggestions + simplified TLDR section, and it now describes types of addressed content before showing how specific URIs map to HTTP gateway. Hopefully this will be easier to follow.

Copy link

@autonome autonome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much clearer, thanks!

@lidel lidel merged commit c89f4e6 into master Feb 4, 2021
@lidel lidel deleted the docs/update-addressing-memo branch February 4, 2021 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants